Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1286123008: X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/x87/instruction-selector-x87.cc
diff --git a/src/compiler/x87/instruction-selector-x87.cc b/src/compiler/x87/instruction-selector-x87.cc
index 04a7d5a09af40ebb8787c354b7e702ceaee64654..446969c664eaf9839ad81bdbe625a8daa4d85f5b 100644
--- a/src/compiler/x87/instruction-selector-x87.cc
+++ b/src/compiler/x87/instruction-selector-x87.cc
@@ -856,7 +856,10 @@ void InstructionSelector::VisitCall(Node* node, BasicBlock* handler) {
InstructionOperand value =
g.CanBeImmediate(input)
? g.UseImmediate(input)
- : IsSupported(ATOM) ? g.UseRegister(input) : g.Use(input);
+ : IsSupported(ATOM) ||
+ sequence()->IsFloat(GetVirtualRegister(input))
+ ? g.UseRegister(input)
+ : g.Use(input);
Emit(kX87Push, g.NoOutput(), value);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698