Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1286123008: X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 838 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 Emit(kX87Poke | MiscField::encode(slot), g.NoOutput(), value); 849 Emit(kX87Poke | MiscField::encode(slot), g.NoOutput(), value);
850 } 850 }
851 } 851 }
852 } else { 852 } else {
853 // Push any stack arguments. 853 // Push any stack arguments.
854 for (Node* input : base::Reversed(buffer.pushed_nodes)) { 854 for (Node* input : base::Reversed(buffer.pushed_nodes)) {
855 // TODO(titzer): handle pushing double parameters. 855 // TODO(titzer): handle pushing double parameters.
856 InstructionOperand value = 856 InstructionOperand value =
857 g.CanBeImmediate(input) 857 g.CanBeImmediate(input)
858 ? g.UseImmediate(input) 858 ? g.UseImmediate(input)
859 : IsSupported(ATOM) ? g.UseRegister(input) : g.Use(input); 859 : IsSupported(ATOM) ||
860 sequence()->IsFloat(GetVirtualRegister(input))
861 ? g.UseRegister(input)
862 : g.Use(input);
860 Emit(kX87Push, g.NoOutput(), value); 863 Emit(kX87Push, g.NoOutput(), value);
861 } 864 }
862 } 865 }
863 866
864 // Pass label of exception handler block. 867 // Pass label of exception handler block.
865 CallDescriptor::Flags flags = descriptor->flags(); 868 CallDescriptor::Flags flags = descriptor->flags();
866 if (handler) { 869 if (handler) {
867 DCHECK_EQ(IrOpcode::kIfException, handler->front()->opcode()); 870 DCHECK_EQ(IrOpcode::kIfException, handler->front()->opcode());
868 IfExceptionHint hint = OpParameter<IfExceptionHint>(handler->front()); 871 IfExceptionHint hint = OpParameter<IfExceptionHint>(handler->front());
869 if (hint == IfExceptionHint::kLocallyCaught) { 872 if (hint == IfExceptionHint::kLocallyCaught) {
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1347 MachineOperatorBuilder::kFloat32Min | 1350 MachineOperatorBuilder::kFloat32Min |
1348 MachineOperatorBuilder::kFloat64Max | 1351 MachineOperatorBuilder::kFloat64Max |
1349 MachineOperatorBuilder::kFloat64Min | 1352 MachineOperatorBuilder::kFloat64Min |
1350 MachineOperatorBuilder::kWord32ShiftIsSafe; 1353 MachineOperatorBuilder::kWord32ShiftIsSafe;
1351 return flags; 1354 return flags;
1352 } 1355 }
1353 1356
1354 } // namespace compiler 1357 } // namespace compiler
1355 } // namespace internal 1358 } // namespace internal
1356 } // namespace v8 1359 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698