Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1286123008: X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. port d0bacc61e6930d97888bf747a76bcfa329995847 (r30235). original commit message: BUG= Committed: https://crrev.com/0afbd7add0a3035acbfcc40dc8894a1ed3280c98 Cr-Commit-Position: refs/heads/master@{#30293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-21 09:28:22 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-21 09:42:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286123008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286123008/1
5 years, 4 months ago (2015-08-21 09:42:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 10:42:24 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 10:42:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0afbd7add0a3035acbfcc40dc8894a1ed3280c98
Cr-Commit-Position: refs/heads/master@{#30293}

Powered by Google App Engine
This is Rietveld 408576698