Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1285673003: When no service response is requested, send null back to the service isolate so it can cleanup (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When no service response is requested, send null back to the service isolate so it can cleanup BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/590557dfd06a29ab7b22e34a549a32142bca8d00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M runtime/bin/vmservice/server.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/service/message.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/developer/extension.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-10 22:35:27 UTC) #2
turnidge
lgtm
5 years, 4 months ago (2015-08-10 22:38:30 UTC) #3
Cutch
5 years, 4 months ago (2015-08-11 14:13:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
590557dfd06a29ab7b22e34a549a32142bca8d00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698