Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: runtime/vm/service/message.dart

Issue 1285673003: When no service response is requested, send null back to the service isolate so it can cleanup (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/json_stream.cc ('k') | sdk/lib/developer/extension.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/message.dart
diff --git a/runtime/vm/service/message.dart b/runtime/vm/service/message.dart
index f27a48bf19f65c8e70d5be0958d53e4e89c29932..c5c37866bd3d082eddfdf774cc01287b2ea857ef 100644
--- a/runtime/vm/service/message.dart
+++ b/runtime/vm/service/message.dart
@@ -94,7 +94,6 @@ class Message {
final receivePort = new RawReceivePort();
receivePort.handler = (value) {
receivePort.close();
- assert(value is String);
_completer.complete(value);
};
var keys = _makeAllString(params.keys.toList(growable:false));
@@ -121,7 +120,6 @@ class Message {
final receivePort = new RawReceivePort();
receivePort.handler = (value) {
receivePort.close();
- assert(value is String);
_completer.complete(value);
};
var keys = _makeAllString(params.keys.toList(growable:false));
« no previous file with comments | « runtime/vm/json_stream.cc ('k') | sdk/lib/developer/extension.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698