clang: Compiler tweaks to make android build for x64

clang: Compiler tweaks to make android build for x64

BUG=402625
Committed: https://crrev.com/5009c0055139d67ecf5affa2067b71013077e0b2
Cr-Commit-Position: refs/heads/master@{#342888}

[agrieve, 2015-08-11 18:07:52]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[agrieve, 2015-08-11 18:59:24]

On 2015/08/11 18:42:52, Dirk Pranke wrote:

Silent treatment?

[agrieve, 2015-08-11 18:59:40]

On 2015/08/11 18:59:24, agrieve wrote:
> On 2015/08/11 18:42:52, Dirk Pranke wrote:
> 
> Silent treatment?

(your reply was blank)

[Dirk Pranke, 2015-08-11 19:40:36]

lgtm.

I hate it when I hit the wrong button :(.

[agrieve, 2015-08-11 19:53:14]

On 2015/08/11 19:40:36, Dirk Pranke wrote:
> lgtm.
> 
> I hate it when I hit the wrong button :(.

:P

[agrieve, 2015-08-11 19:53:18]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-08-11 19:53:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285623003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285623003/1

[commit-bot: I haz the power, 2015-08-11 21:02:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-11 21:03:15]

Patchset 1 (id:??) landed as
https://crrev.com/5009c0055139d67ecf5affa2067b71013077e0b2
Cr-Commit-Position: refs/heads/master@{#342888}

[Nico, 2015-08-11 21:06:14]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-08-11 21:06:15]

https://codereview.chromium.org/1285623003/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1285623003/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:563: # GCC provides this as a built-in macro, but
clang does not.
Under which circumstances? Based on the triple? Is there a clang bug filed for
this? This seems something we should be able to fix very quickly.

[agrieve, 2015-08-12 01:43:43]

On 2015/08/11 21:06:15, Nico (hiding) wrote:
>
https://codereview.chromium.org/1285623003/diff/1/build/config/compiler/BUILD.gn
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1285623003/diff/1/build/config/compiler/BUILD...
> build/config/compiler/BUILD.gn:563: # GCC provides this as a built-in macro,
but
> clang does not.
> Under which circumstances? Based on the triple? Is there a clang bug filed for
> this? This seems something we should be able to fix very quickly.

I actually didn't even verify the validity of the statement. Just copied it from
clank/suppliement.gypi, where it's existed since 2012. Just tested and it is in
fact defined for both gcc and clang, so I'll revert it (and remove it from
clank/supplement.gypi)

[agrieve, 2015-08-12 17:46:47]

On 2015/08/12 01:43:43, agrieve wrote:
> On 2015/08/11 21:06:15, Nico (hiding) wrote:
> >
>
https://codereview.chromium.org/1285623003/diff/1/build/config/compiler/BUILD.gn
> > File build/config/compiler/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/1285623003/diff/1/build/config/compiler/BUILD...
> > build/config/compiler/BUILD.gn:563: # GCC provides this as a built-in macro,
> but
> > clang does not.
> > Under which circumstances? Based on the triple? Is there a clang bug filed
for
> > this? This seems something we should be able to fix very quickly.
> 
> I actually didn't even verify the validity of the statement. Just copied it
from
> clank/suppliement.gypi, where it's existed since 2012. Just tested and it is
in
> fact defined for both gcc and clang, so I'll revert it (and remove it from
> clank/supplement.gypi)

https://codereview.chromium.org/1284093002/