Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1284093002: GN: Don't explicitly define __ANDROID__ now that clang defines it automatically (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-clang1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't explicitly define __ANDROID__ now that clang defines it automatically BUG=402625 Committed: https://crrev.com/566f1e310289474839002875bf25d4321a65087d Cr-Commit-Position: refs/heads/master@{#343055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
agrieve
5 years, 4 months ago (2015-08-12 03:23:58 UTC) #2
agrieve
On 2015/08/12 03:23:58, agrieve wrote: Relevant upstream change: https://chrome-internal-review.googlesource.com/#/c/226765/1
5 years, 4 months ago (2015-08-12 03:24:53 UTC) #3
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-12 17:13:31 UTC) #4
Nico
lgtm http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120423/056751.html is the change that made clang define this – way over 3 years ...
5 years, 4 months ago (2015-08-12 17:18:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284093002/1
5 years, 4 months ago (2015-08-12 17:46:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 18:13:48 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:14:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/566f1e310289474839002875bf25d4321a65087d
Cr-Commit-Position: refs/heads/master@{#343055}

Powered by Google App Engine
This is Rietveld 408576698