Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285433002: Fix win unit tests broken at 9778206 (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix win unit tests broken at 9778206. Windows uses the system implementation of itoa which goes to 36. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/290b2351d06f0bc994e58394ab948244c08e82af

Patch Set 1 #

Patch Set 2 : Try again. #

Patch Set 3 : Kill memset. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M core/src/fxcrt/fx_system_unittest.cpp View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
TBR, tests broken.
5 years, 4 months ago (2015-08-07 22:47:41 UTC) #2
Tom Sepez
On 2015/08/07 22:47:41, Tom Sepez wrote: > TBR, tests broken. Hang on, its probably easy ...
5 years, 4 months ago (2015-08-07 22:51:38 UTC) #3
Tom Sepez
On 2015/08/07 22:51:38, Tom Sepez wrote: > On 2015/08/07 22:47:41, Tom Sepez wrote: > > ...
5 years, 4 months ago (2015-08-07 23:08:07 UTC) #4
Tom Sepez
Committed patchset #3 (id:40001) manually as 290b2351d06f0bc994e58394ab948244c08e82af (tree was closed).
5 years, 4 months ago (2015-08-07 23:08:33 UTC) #5
Lei Zhang
5 years, 4 months ago (2015-08-07 23:20:15 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698