Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: core/src/fxcrt/fx_system_unittest.cpp

Issue 1285433002: Fix win unit tests broken at 9778206 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Kill memset. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/fx_system_unittest.cpp
diff --git a/core/src/fxcrt/fx_system_unittest.cpp b/core/src/fxcrt/fx_system_unittest.cpp
index ae1e41c77e0e1b267dc9367fb260a11bbd239c83..e1a986e72d9f04c5a574be0382150c0ca0499607 100644
--- a/core/src/fxcrt/fx_system_unittest.cpp
+++ b/core/src/fxcrt/fx_system_unittest.cpp
@@ -73,7 +73,11 @@ void Check64BitBase2Itoa(int64_t input, const char* expected_output) {
TEST(fxcrt, FXSYS_itoa_InvalidRadix) {
FX_CHAR buf[32];
- FXSYS_itoa(42, buf, 17);
+#if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
+ FXSYS_itoa(42, buf, 17); // Ours stops at 16.
+#else
+ FXSYS_itoa(42, buf, 37); // Theirs goes up to 36.
+#endif
EXPECT_EQ(std::string(""), buf);
FXSYS_itoa(42, buf, 1);
@@ -114,7 +118,11 @@ TEST(fxcrt, FXSYS_itoa) {
TEST(fxcrt, FXSYS_i64toa_InvalidRadix) {
FX_CHAR buf[32];
- FXSYS_i64toa(42, buf, 17);
+#if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
+ FXSYS_i64toa(42, buf, 17); // Ours stops at 16.
+#else
+ FXSYS_i64toa(42, buf, 37); // Theirs goes up to 36.
+#endif
EXPECT_EQ(std::string(""), buf);
FXSYS_i64toa(42, buf, 1);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698