Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285283002: Refactor helper function for SkBitmapShader to GrFragmentProcessor (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Refactor helper function for SkBitmapShader to GrFragmentProcessor BUG=skia: Committed: https://skia.googlesource.com/skia/+/9bc3954fc1b6c3fb609cbb10d42f659b9d762eb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -71 lines) Patch
M include/gpu/SkGr.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +6 lines, -37 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +4 lines, -33 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
ptal, a small refactor CL
5 years, 4 months ago (2015-08-12 18:43:08 UTC) #2
joshualitt
adding Brian
5 years, 4 months ago (2015-08-12 19:46:06 UTC) #4
bsalomon
On 2015/08/12 19:46:06, joshualitt wrote: > adding Brian lgtm
5 years, 4 months ago (2015-08-12 19:48:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285283002/1
5 years, 4 months ago (2015-08-12 19:49:07 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 19:57:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9bc3954fc1b6c3fb609cbb10d42f659b9d762eb0

Powered by Google App Engine
This is Rietveld 408576698