Issue 1285263007: Revert of cast SK_ARRAY_COUNT to make it sign agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1285263007: Revert of cast SK_ARRAY_COUNT to make it sign agnostic (Closed)

Created:
5 years, 4 months ago by caryclark

Modified:
5 years, 4 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of cast SK_ARRAY_COUNT to make it sign agnostic (patchset #1 id:1 of https://codereview.chromium.org/1299943002/ ) Reason for revert: fails on chrome build on windows Original issue's description: > cast SK_ARRAY_COUNT to make it sign agnostic > > By adding a cast to SK_ARRAY_COUNT, the compiler treats the > compile-time value as if it were a const int, and like regular > numbers, permits it to be compared to signed and unsigned > numbers freely. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/bca86202a48b2afa527b6e40d8b360ce3bc7c2e7 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/95b96d649547c6b89ae0eca0f88f965d90c531a5

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkTypes.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

caryclark

Created Revert of cast SK_ARRAY_COUNT to make it sign agnostic

5 years, 4 months ago (2015-08-19 17:12:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285263007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285263007/1

5 years, 4 months ago (2015-08-19 17:12:53 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-19 17:13:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/95b96d649547c6b89ae0eca0f88f965d90c531a5

Expand Messages | Collapse Messages