include/core/SkTypes.h - Issue 1285263007: Revert of cast SK_ARRAY_COUNT to make it sign agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTypes.h

Issue 1285263007: Revert of cast SK_ARRAY_COUNT to make it sign agnostic (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTypes.h

diff --git a/include/core/SkTypes.h b/include/core/SkTypes.h

index fb1cceccc3b0cd0d0f0db80b1d863a8823cc88b0..2e495117d83b5dc80c156dea636882626e1cf22f 100644

--- a/include/core/SkTypes.h

+++ b/include/core/SkTypes.h

@@ -305,7 +305,7 @@

/** Returns the number of entries in an array (not a pointer) */

template <typename T, size_t N> char (&SkArrayCountHelper(T (&array)[N]))[N];

-#define SK_ARRAY_COUNT(array) ((int) sizeof(SkArrayCountHelper(array)))

+#define SK_ARRAY_COUNT(array) (sizeof(SkArrayCountHelper(array)))

#define SkAlign2(x) (((x) + 1) >> 1 << 1)

#define SkIsAlign2(x) (0 == ((x) & 1))

« no previous file with comments | « no previous file | no next file » | no next file with comments »