Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 1285203003: Fix the missing wallpaper reference link and icon of the built-in wallpapers at the bottom of Wallp… (Closed)

Created:
5 years, 4 months ago by xdai1
Modified:
5 years, 4 months ago
Reviewers:
bshe
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the missing wallpaper reference link and icon of the built-in wallpapers at the bottom of Wallpaper Picker. It's a bug revealed by https://codereview.chromium.org/1227413005. BUG=516531 Committed: https://crrev.com/4e6150b17e8304c1a252d19fb991077ed5385c5f Cr-Commit-Position: refs/heads/master@{#343942}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/main.html View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (2 generated)
xdai1
Biao, could you help to review this CL please? Thanks!
5 years, 4 months ago (2015-08-14 23:44:32 UTC) #2
bshe
https://codereview.chromium.org/1285203003/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/main.html File chrome/browser/resources/chromeos/wallpaper_manager/main.html (right): https://codereview.chromium.org/1285203003/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/main.html#newcode109 chrome/browser/resources/chromeos/wallpaper_manager/main.html:109: <div id="online-wallpaper-attribute"> can you verify if online-wallpaper-attribute is not ...
5 years, 4 months ago (2015-08-17 16:21:50 UTC) #3
xdai1
On 2015/08/17 16:21:50, bshe wrote: > https://codereview.chromium.org/1285203003/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/main.html > File chrome/browser/resources/chromeos/wallpaper_manager/main.html (right): > > https://codereview.chromium.org/1285203003/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/main.html#newcode109 > ...
5 years, 4 months ago (2015-08-17 16:59:37 UTC) #4
bshe
On 2015/08/17 16:59:37, xdai1 wrote: > On 2015/08/17 16:21:50, bshe wrote: > > > https://codereview.chromium.org/1285203003/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/main.html ...
5 years, 4 months ago (2015-08-18 14:08:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285203003/1
5 years, 4 months ago (2015-08-18 16:20:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 16:48:41 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 16:49:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e6150b17e8304c1a252d19fb991077ed5385c5f
Cr-Commit-Position: refs/heads/master@{#343942}

Powered by Google App Engine
This is Rietveld 408576698