Disable Delete option for custom wallpapers when 'Surprise Me' is enabled.

Disable Delete option for custom wallpapers when 'Surprise Me' is enabled.

BUG=509859
TEST=manually tested

Committed: https://crrev.com/9626ec9f9c86c1d3a9d49b4f3edc508831546ee3
Cr-Commit-Position: refs/heads/master@{#339093}

[xdai1, 2015-07-14 23:39:08]

xdai@chromium.org changed reviewers:
+ bshe@chromium.org

[xdai1, 2015-07-14 23:39:08]

Biao, could you help to review the CL please? Thanks!

[bshe, 2015-07-15 18:40:49]

https://codereview.chromium.org/1227413005/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
(right):

https://codereview.chromium.org/1227413005/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js:207:
self.document_.body.removeAttribute('custom');
custom should only be used to indicate if we are at custom wallpaper tab.
Changing this property based on the state of surprise me feature is kind of
unexpected. We probably want to introduce a new property and use css rules to
hide the context menu. WDYT?

[xdai1, 2015-07-16 01:21:40]

Biao, I've addressed your comment. Please take another look, thanks for your
review!

[bshe, 2015-07-16 13:57:56]

lgtm

https://codereview.chromium.org/1227413005/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

https://codereview.chromium.org/1227413005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:278:
display: none !important;
you can probably combine this with the rules above?

[xdai1, 2015-07-16 16:25:50]

On 2015/07/16 13:57:56, bshe wrote:
> lgtm
> 
>
https://codereview.chromium.org/1227413005/diff/20001/chrome/browser/resource...
> File
> chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
> (right):
> 
>
https://codereview.chromium.org/1227413005/diff/20001/chrome/browser/resource...
>
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:278:
> display: none !important;
> you can probably combine this with the rules above?

Done. Thanks for the review!

[xdai1, 2015-07-16 16:26:17]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2015-07-16 16:26:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1227413005/#ps40001
(title: "Address Biao's comment.")

[commit-bot: I haz the power, 2015-07-16 16:27:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227413005/40001

[commit-bot: I haz the power, 2015-07-16 17:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 17:16:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xdai1, 2015-07-16 18:53:06]

On 2015/07/16 13:57:56, bshe wrote:
> lgtm
> 
>
https://codereview.chromium.org/1227413005/diff/20001/chrome/browser/resource...
> File
> chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
> (right):
> 
>
https://codereview.chromium.org/1227413005/diff/20001/chrome/browser/resource...
>
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:278:
> display: none !important;
> you can probably combine this with the rules above?

Reverted the combination back since it broken
linux_chromium_chromeos_compile_dbg_ng.

[xdai1, 2015-07-16 18:54:03]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2015-07-16 18:54:04]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1227413005/#ps60001
(title: "Reverted the combination....")

[commit-bot: I haz the power, 2015-07-16 18:54:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227413005/60001

[commit-bot: I haz the power, 2015-07-16 19:25:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-16 19:26:28]

Patchset 4 (id:??) landed as
https://crrev.com/9626ec9f9c86c1d3a9d49b4f3edc508831546ee3
Cr-Commit-Position: refs/heads/master@{#339093}