components/autofill/browser/form_structure.cc - Issue 12852003: Autofill:Autocheckout: Enable looking at all elements for Autocheckout flow (ignoring 3 element lim…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/form_structure.cc

Issue 12852003: Autofill:Autocheckout: Enable looking at all elements for Autocheckout flow (ignoring 3 element lim… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments and more tests. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/browser/autofill_manager_unittest.cc ('k') | components/autofill/browser/form_structure_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/form_structure.cc

diff --git a/components/autofill/browser/form_structure.cc b/components/autofill/browser/form_structure.cc

index ba80803642d08d021b5f070310fe19e27d00ab4f..be0e8a550580a97322dfa1e21041d6db9cf924b4 100644

--- a/components/autofill/browser/form_structure.cc

+++ b/components/autofill/browser/form_structure.cc

@@ -637,7 +637,9 @@ bool FormStructure::ShouldBeParsed(bool require_method_post) const {

}

bool FormStructure::ShouldBeCrowdsourced() const {

- return !has_author_specified_types_ && ShouldBeParsed(true);

+ // Allow all forms in Autocheckout flow to be crowdsourced.

+ return (!has_author_specified_types_ && ShouldBeParsed(true)) ||

+ IsAutocheckoutEnabled();

}

void FormStructure::UpdateFromCache(const FormStructure& cached_form) {

« no previous file with comments | « components/autofill/browser/autofill_manager_unittest.cc ('k') | components/autofill/browser/form_structure_unittest.cc » ('j') | no next file with comments »