Autofill:Autocheckout: Enable looking at all elements for Autocheckout flow (ignoring 3 element lim…

components/autofill/browser/form_structure.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/form_structure.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 595 matching lines @@
     if (field && field->IsFieldFillable())
       ++autofill_count_;
   }
 }
 
 bool FormStructure::ShouldBeParsed(bool require_method_post) const {
   // Ignore counting checkable elements towards minimum number of elements
   // required to parse. This avoids trying to crowdsource forms with few text
   // or select elements.
   if ((field_count() - checkable_field_count()) < RequiredFillableFields())
     return false;

[Ilya Sherman, 2013/03/18 22:25:40]

Did you intentionally move this code back?

[Raman Kakilate, 2013/03/18 22:36:01]

Yes. RequiredFillableFields() does IsAutocheckoutEnabled() check internally.

 
   // Rule out http(s)://*/search?...
   //  e.g. http://www.google.com/search?q=...
   //       http://search.yahoo.com/search?p=...
   if (target_url_.path() == "/search")
     return false;
 
   if (!IsAutocheckoutEnabled()) {
     // Make sure there is at least one text field when Autocheckout is
     // not enabled.
     bool has_text_field = false;
     for (std::vector<AutofillField*>::const_iterator it = begin();
          it != end() && !has_text_field; ++it) {
       has_text_field |= (*it)->form_control_type != "select-one";
     }
     if (!has_text_field)
       return false;
   }
 
   return !require_method_post || (method_ == POST);
 }
 
 bool FormStructure::ShouldBeCrowdsourced() const {
-  return !has_author_specified_types_ && ShouldBeParsed(true);
+  // Allow all forms in Autocheckout flow to be crowdsourced.
+  return (!has_author_specified_types_ && ShouldBeParsed(true)) ||
+      IsAutocheckoutEnabled();
 }
 
 void FormStructure::UpdateFromCache(const FormStructure& cached_form) {
   // Map from field signatures to cached fields.
   std::map<std::string, const AutofillField*> cached_fields;
   for (size_t i = 0; i < cached_form.field_count(); ++i) {
     const AutofillField* field = cached_form.field(i);
     cached_fields[field->FieldSignature()] = field;
   }
 
@@ skipping 497 matching lines @@
   for (std::vector<AutofillField*>::iterator field = fields_.begin();
        field != fields_.end(); ++field) {
     AutofillType::FieldTypeGroup field_type_group =
         AutofillType((*field)->type()).group();
     if (field_type_group == AutofillType::CREDIT_CARD)
       (*field)->set_section((*field)->section() + "-cc");
     else
       (*field)->set_section((*field)->section() + "-default");
   }
 }