Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285193004: Move willColorBlendWithDst from pipeline builder to GrPipelineOptimizations. (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xpfail
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move willColorBlendWithDst from pipeline builder to GrPipelineOptimizations. Committed: https://skia.googlesource.com/skia/+/2d563030a83ce544bee999b5abe658cbf002587e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M src/gpu/GrBufferedDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
bsalomon
Minor change... decided to punt on removing PipelineInfo entirely until later in this set of ...
5 years, 4 months ago (2015-08-13 13:38:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285193004/1
5 years, 4 months ago (2015-08-13 13:39:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-13 13:39:01 UTC) #5
egdaniel
lgtm with nit https://codereview.chromium.org/1285193004/diff/1/src/gpu/GrPrimitiveProcessor.h File src/gpu/GrPrimitiveProcessor.h (right): https://codereview.chromium.org/1285193004/diff/1/src/gpu/GrPrimitiveProcessor.h#newcode123 src/gpu/GrPrimitiveProcessor.h:123: * overlapping draws into a single ...
5 years, 4 months ago (2015-08-13 13:45:29 UTC) #7
bsalomon
https://codereview.chromium.org/1285193004/diff/1/src/gpu/GrPrimitiveProcessor.h File src/gpu/GrPrimitiveProcessor.h (right): https://codereview.chromium.org/1285193004/diff/1/src/gpu/GrPrimitiveProcessor.h#newcode123 src/gpu/GrPrimitiveProcessor.h:123: * overlapping draws into a single draw (really to ...
5 years, 4 months ago (2015-08-13 13:53:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285193004/20001
5 years, 4 months ago (2015-08-13 13:53:51 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 14:08:34 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2d563030a83ce544bee999b5abe658cbf002587e

Powered by Google App Engine
This is Rietveld 408576698