Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1285133005: DevTools: unflake DOM debugger tests (Closed)

Created:
5 years, 4 months ago by yurys
Modified:
5 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: unflake DOM debugger tests enabled property should be cleared on InspectorState when DOMDebugger gets disabled. BUG=521036, 521106 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200616

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
yurys
5 years, 4 months ago (2015-08-14 19:22:47 UTC) #2
dgozman
lgtm
5 years, 4 months ago (2015-08-14 19:24:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285133005/1
5 years, 4 months ago (2015-08-14 19:26:17 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 4 months ago (2015-08-14 20:37:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285133005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285133005/20001
5 years, 4 months ago (2015-08-14 21:36:42 UTC) #11
commit-bot: I haz the power
Failed to apply patch for Source/core/inspector/InspectorDOMDebuggerAgent.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 4 months ago (2015-08-14 23:39:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285133005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285133005/60001
5 years, 4 months ago (2015-08-14 23:54:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/56128)
5 years, 4 months ago (2015-08-15 01:54:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285133005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285133005/60001
5 years, 4 months ago (2015-08-16 16:00:20 UTC) #21
commit-bot: I haz the power
5 years, 4 months ago (2015-08-16 17:43:03 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200616

Powered by Google App Engine
This is Rietveld 408576698