Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 1285133005: DevTools: unflake DOM debugger tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMDebuggerAgent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
index ac2a01dc36f8d2ae02251d837cb3110f7bc5b8ed..8ae0021189c020b6b77131d0ad62e3bfc67b1a55 100644
--- a/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
@@ -121,7 +121,7 @@ DEFINE_TRACE(InspectorDOMDebuggerAgent)
void InspectorDOMDebuggerAgent::disable(ErrorString*)
{
- m_instrumentingAgents->setInspectorDOMDebuggerAgent(nullptr);
+ setEnabled(false);
m_domBreakpoints.clear();
m_state->remove(DOMDebuggerAgentState::eventListenerBreakpoints);
m_state->remove(DOMDebuggerAgentState::xhrBreakpoints);
@@ -634,8 +634,7 @@ void InspectorDOMDebuggerAgent::didAddBreakpoint()
{
if (m_state->getBoolean(DOMDebuggerAgentState::enabled))
return;
- m_instrumentingAgents->setInspectorDOMDebuggerAgent(this);
- m_state->setBoolean(DOMDebuggerAgentState::enabled, true);
+ setEnabled(true);
}
static bool isEmpty(PassRefPtr<JSONObject> object)
@@ -653,8 +652,18 @@ void InspectorDOMDebuggerAgent::didRemoveBreakpoint()
return;
if (m_state->getBoolean(DOMDebuggerAgentState::pauseOnAllXHRs))
return;
- m_state->remove(DOMDebuggerAgentState::enabled);
- m_instrumentingAgents->setInspectorDOMDebuggerAgent(nullptr);
+ setEnabled(false);
+}
+
+void InspectorDOMDebuggerAgent::setEnabled(bool enabled)
+{
+ if (enabled) {
+ m_instrumentingAgents->setInspectorDOMDebuggerAgent(this);
+ m_state->setBoolean(DOMDebuggerAgentState::enabled, true);
+ } else {
+ m_state->remove(DOMDebuggerAgentState::enabled);
+ m_instrumentingAgents->setInspectorDOMDebuggerAgent(nullptr);
+ }
}
} // namespace blink
« no previous file with comments | « Source/core/inspector/InspectorDOMDebuggerAgent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698