chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h - Issue 12851002: Remove ConstrainedWindowGtkDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h

Issue 12851002: Remove ConstrainedWindowGtkDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc ('K') | « chrome/browser/ui/gtk/ssl_client_certificate_selector.cc ('k') | chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h

diff --git a/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h b/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h

index 95ce5b96d2bf5f5753a79ccfa24a3d29c1579f56..eac550fe099831879db8861a4726d0de6cc836df 100644

--- a/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h

+++ b/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h

@@ -9,7 +9,7 @@

#include "base/memory/scoped_ptr.h"

#include "content/public/browser/web_contents_view_delegate.h"

#include "ui/base/gtk/gtk_signal.h"

-#include "ui/base/gtk/owned_widget_gtk.h"

+#include "ui/base/gtk/scoped_gobject.h"

class RenderViewContextMenuGtk;

class WebDragBookmarkHandlerGtk;

@@ -57,7 +57,7 @@ class ChromeWebContentsViewDelegateGtk

GtkAllocation*);

// Contains |expanded_| as its GtkBin member.

- ui::OwnedWidgetGtk floating_;

+ ui::ScopedGObject<GtkWidget>::Type floating_;

Elliot Glaysher 2013/03/13 23:48:10 This makes me slightly nervous. Why are you changi

Mike Wittman 2013/03/14 00:34:48 OwnedWidgetGtk requires that it be the last entity

// The UI for the web contents modal dialog currently displayed. This is owned

// by WebContents, not the view.