chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc - Issue 12851002: Remove ConstrainedWindowGtkDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

Issue 12851002: Remove ConstrainedWindowGtkDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h ('K') | « chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h ('k') | chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

diff --git a/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc b/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

index 28c74f21f5c132bbacac3dee05fda984060c67d4..4a8eac83479083cb8059ec9c029047814f80c6b1 100644

--- a/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

+++ b/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

@@ -52,6 +52,7 @@ ChromeWebContentsViewDelegateGtk::ChromeWebContentsViewDelegateGtk(

web_contents_(web_contents),

expanded_container_(NULL),

focus_store_(NULL) {

+ g_object_ref_sink(floating_.get());

gtk_widget_set_name(floating_.get(), "chrome-tab-contents-view");

g_signal_connect(floating_.get(), "set-floating-position",

G_CALLBACK(OnSetFloatingPositionThunk), this);

@@ -62,7 +63,6 @@ ChromeWebContentsViewDelegateGtk::ChromeWebContentsViewDelegateGtk(

}

ChromeWebContentsViewDelegateGtk::~ChromeWebContentsViewDelegateGtk() {

- floating_.Destroy();

}

void ChromeWebContentsViewDelegateGtk::AttachWebContentsModalDialog(