Move download filename determintion into a separate class.

chrome/browser/download/download_test_file_activity_observer.cc

Index: chrome/browser/download/download_test_file_activity_observer.cc
diff --git a/chrome/browser/download/download_test_file_activity_observer.cc b/chrome/browser/download/download_test_file_activity_observer.cc
index 2137409dea736177b4e7bfb4ec306df8d5eeeabc..c01d5f43d282b48ca5d7dc93411a1f5996e3c721 100644
--- a/chrome/browser/download/download_test_file_activity_observer.cc
+++ b/chrome/browser/download/download_test_file_activity_observer.cc
@@ -38,14 +38,16 @@ class DownloadTestFileActivityObserver::MockDownloadManagerDelegate
 
  protected:
 
-  virtual void ChooseDownloadPath(content::DownloadItem* item,
-                                  const base::FilePath& suggested_path,
-                                  const FileSelectedCallback&
-                                      callback) OVERRIDE {
+  virtual void PromptUserForDownloadPath(
+      content::DownloadItem* item,
+      const base::FilePath& suggested_path,
+      const DownloadTargetDeterminerDelegate::FileSelectedCallback&
+          callback) OVERRIDE {
+    base::FilePath target_path =
+        file_chooser_enabled_ ? suggested_path : base::FilePath();
     file_chooser_displayed_ = true;
     MessageLoop::current()->PostTask(
-        FROM_HERE, base::Bind(callback, (file_chooser_enabled_ ? suggested_path
-                                         : base::FilePath())));
+        FROM_HERE, base::Bind(callback, target_path));

[Randy Smith (Not in Mondays), 2013/04/26 19:05:46]

Why the change?  I don't object, but it looks semantically null to me, and I
don't see the readability improvement.

[asanka, 2013/04/29 18:43:20]

Ah. This was an artifact of doing and undoing a few changes by hand :-/. Fixed.

   }
 
   virtual void OpenDownload(content::DownloadItem* item) OVERRIDE {}