Move download filename determintion into a separate class.

chrome/browser/download/download_test_file_activity_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_test_file_activity_observer.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_service.h"
@@ skipping 20 matching lines @@
   }
 
   bool TestAndResetDidShowFileChooser() {
     bool did_show = file_chooser_displayed_;
     file_chooser_displayed_ = false;
     return did_show;
   }
 
  protected:
 
-  virtual void ChooseDownloadPath(content::DownloadItem* item,
-                                  const base::FilePath& suggested_path,
-                                  const FileSelectedCallback&
-                                      callback) OVERRIDE {
+  virtual void PromptUserForDownloadPath(
+      content::DownloadItem* item,
+      const base::FilePath& suggested_path,
+      const DownloadTargetDeterminerDelegate::FileSelectedCallback&
+          callback) OVERRIDE {
+    base::FilePath target_path =
+        file_chooser_enabled_ ? suggested_path : base::FilePath();
     file_chooser_displayed_ = true;
     MessageLoop::current()->PostTask(
-        FROM_HERE, base::Bind(callback, (file_chooser_enabled_ ? suggested_path
-                                         : base::FilePath())));
+        FROM_HERE, base::Bind(callback, target_path));

[Randy Smith (Not in Mondays), 2013/04/26 19:05:46]

Why the change?  I don't object, but it looks semantically null to me, and I
don't see the readability improvement.

[asanka, 2013/04/29 18:43:20]

Ah. This was an artifact of doing and undoing a few changes by hand :-/. Fixed.

   }
 
   virtual void OpenDownload(content::DownloadItem* item) OVERRIDE {}
 
  private:
   virtual ~MockDownloadManagerDelegate() {}
 
   bool file_chooser_enabled_;
   bool file_chooser_displayed_;
 };
 
 DownloadTestFileActivityObserver::DownloadTestFileActivityObserver(
     Profile* profile) {
   test_delegate_ = new MockDownloadManagerDelegate(profile);
   DownloadServiceFactory::GetForProfile(profile)->
       SetDownloadManagerDelegateForTesting(test_delegate_.get());
 }
 
 DownloadTestFileActivityObserver::~DownloadTestFileActivityObserver() {
 }
 
 void DownloadTestFileActivityObserver::EnableFileChooser(bool enable) {
   test_delegate_->EnableFileChooser(enable);
 }
 
 bool DownloadTestFileActivityObserver::TestAndResetDidShowFileChooser() {
   return test_delegate_->TestAndResetDidShowFileChooser();
 }