Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284893002: Reland: [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stac… (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. OCL: https://codereview.chromium.org/1263033004/ R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/17f4c5bbaf3775df6002db1965e2702bdba2a520 Cr-Commit-Position: refs/heads/master@{#30115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+828 lines, -140 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +8 lines, -13 lines 0 comments Download
M src/compiler/frame.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/machine-type.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +8 lines, -5 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 3 chunks +13 lines, -14 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 3 chunks +10 lines, -16 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/c-signature.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 3 chunks +7 lines, -6 lines 0 comments Download
A test/cctest/compiler/test-run-native-calls.cc View 1 chunk +674 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 4 months ago (2015-08-11 14:49:53 UTC) #1
Michael Starzinger
LGTM on the added changes to MIPS, didn't look at the rest.
5 years, 4 months ago (2015-08-11 14:52:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284893002/1
5 years, 4 months ago (2015-08-11 15:21:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 15:23:10 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 15:23:24 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/17f4c5bbaf3775df6002db1965e2702bdba2a520
Cr-Commit-Position: refs/heads/master@{#30115}

Powered by Google App Engine
This is Rietveld 408576698