Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1284723006: Add a --force flag to get_toolchain_if_necessary.py to let it run on non-Windows. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a --force flag to get_toolchain_if_necessary.py to let it run on non-Windows. BUG=495204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Goes with https://codereview.chromium.org/1277913006
5 years, 4 months ago (2015-08-11 21:57:02 UTC) #2
scottmg
lgtm
5 years, 4 months ago (2015-08-11 21:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284723006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284723006/1
5 years, 4 months ago (2015-08-11 22:03:48 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 22:06:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296272

Powered by Google App Engine
This is Rietveld 408576698