Let build/vs_toolchain.py run on non-Windows if requested.

Let build/vs_toolchain.py run on non-Windows if requested.

If `build/vs_toolchain.py update --force` is run once on non-Windows, the
script will start keeping a Windows toolchain in depot_tools up-to-date, and
it'll copy runtime dlls into the build directory, and so on.  (One can delete
build/win_toolchain.json to disable this behavior again.)

Depends on https://codereview.chromium.org/1284723006
BUG=495204
Committed: https://crrev.com/4f4b137f26afe39a02f789832e840757b11f088d
Cr-Commit-Position: refs/heads/master@{#342917}

[Nico, 2015-08-11 21:58:40]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-08-11 22:08:15]

lgtm

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (left):

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#oldco...
build/vs_toolchain.py:243: if not sys.platform.startswith(('win32', 'cygwin')):
i'm slightly nervous about this failing somewhere because of all the things that
call this now, but i can't find any. fingers crossed!

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:35: if (sys.platform in ('win32', 'cygwin') and
depot_tools_win_toolchain or
can you add more () here? `a and b or c` always confuses me

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:206: if force == '--force' or
os.path.exists(json_data_file):
what crazy person made `json_data_file` a global? (me :()

[Nico, 2015-08-11 22:11:48]

Thanks!

Rietveld's "Ack" button is pretty great.

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:35: if (sys.platform in ('win32', 'cygwin') and
depot_tools_win_toolchain or
On 2015/08/11 22:08:15, scottmg (returning - slow) wrote:
> can you add more () here? `a and b or c` always confuses me

Done.

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:206: if force == '--force' or
os.path.exists(json_data_file):
On 2015/08/11 22:08:15, scottmg (returning - slow) wrote:
> what crazy person made `json_data_file` a global? (me :()

Acknowledged.

[Nico, 2015-08-11 22:12:07]

On 2015/08/11 22:11:48, Nico (hiding) wrote:
> Thanks!
> 
> Rietveld's "Ack" button is pretty great.
> 
> https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py
> File build/vs_toolchain.py (right):
> 
>
https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
> build/vs_toolchain.py:35: if (sys.platform in ('win32', 'cygwin') and
> depot_tools_win_toolchain or
> On 2015/08/11 22:08:15, scottmg (returning - slow) wrote:
> > can you add more () here? `a and b or c` always confuses me
> 
> Done.
> 
>
https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
> build/vs_toolchain.py:206: if force == '--force' or
> os.path.exists(json_data_file):
> On 2015/08/11 22:08:15, scottmg (returning - slow) wrote:
> > what crazy person made `json_data_file` a global? (me :()
> 
> Acknowledged.

So matter-of-fact!

[Nico, 2015-08-11 22:12:27]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-08-11 22:12:28]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1277913006/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2015-08-11 22:13:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277913006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277913006/20001

[scottmg, 2015-08-11 22:15:57]

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:206: if force == '--force' or
os.path.exists(json_data_file):
On 2015/08/11 22:11:47, Nico (hiding) wrote:
> On 2015/08/11 22:08:15, scottmg (returning - slow) wrote:
> > what crazy person made `json_data_file` a global? (me :()
> 
> Acknowledged.

Acknowledged.

[Nico, 2015-08-11 22:19:51]

On Tue, Aug 11, 2015 at 3:15 PM, <scottmg@chromium.org> wrote:

>
> https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py
> File build/vs_toolchain.py (right):
>
>
>
https://codereview.chromium.org/1277913006/diff/1/build/vs_toolchain.py#newco...
> build/vs_toolchain.py:206: if force == '--force' or
> os.path.exists(json_data_file):
> On 2015/08/11 22:11:47, Nico (hiding) wrote:
>
>> On 2015/08/11 22:08:15, scottmg (returning - slow) wrote:
>> > what crazy person made `json_data_file` a global? (me :()
>>
>
> Acknowledged.
>>
>
> Acknowledged.


:-D
https://lh5.googleusercontent.com/-t5TbO1QEeVo/T0MdMb8UuhI/AAAAAAAAUjo/oZ6rfK...

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-08-11 22:25:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-11 22:25:38]

Patchset 2 (id:??) landed as
https://crrev.com/4f4b137f26afe39a02f789832e840757b11f088d
Cr-Commit-Position: refs/heads/master@{#342917}