Chromium Code Reviews| Index: chrome/common/extensions/features/simple_feature.h |
| diff --git a/chrome/common/extensions/features/simple_feature.h b/chrome/common/extensions/features/simple_feature.h |
| index 5b34c6e68f3269997a79ea6284f98bc374b3f993..cd64279dff3b021e9b0fdb21b764d60a23a59b70 100644 |
| --- a/chrome/common/extensions/features/simple_feature.h |
| +++ b/chrome/common/extensions/features/simple_feature.h |
| @@ -31,7 +31,7 @@ class SimpleFeature : public Feature { |
| // Parses the JSON representation of a feature into the fields of this object. |
| // Unspecified values in the JSON are not modified in the object. This allows |
| // us to implement inheritance by parsing one value after another. |
| - void Parse(const DictionaryValue* value); |
| + virtual bool Parse(const DictionaryValue* value); |
|
not at google - send to devlin
2013/03/26 00:34:48
I think this should return a std::string error rat
cduvall
2013/03/26 19:24:05
Done.
|
| // Returns true if the feature contains the same values as another. |
| bool Equals(const SimpleFeature& other) const; |