Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Unified Diff: chrome/common/extensions/features/permission_feature.cc

Issue 12846011: Implement API features for the Extension API feature system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/permission_feature.cc
diff --git a/chrome/common/extensions/features/permission_feature.cc b/chrome/common/extensions/features/permission_feature.cc
index 1f5da626995751a25540285db3da55a47a772af0..c4970946895ea69207f211cc552011681d955d33 100644
--- a/chrome/common/extensions/features/permission_feature.cc
+++ b/chrome/common/extensions/features/permission_feature.cc
@@ -36,4 +36,21 @@ Feature::Availability PermissionFeature::IsAvailableToContext(
return CreateAvailability(IS_AVAILABLE);
}
+bool PermissionFeature::Parse(const DictionaryValue* value) {
+ if (!SimpleFeature::Parse(value))
+ return false;
+
+ if (extension_types()->empty()) {
+ LOG(ERROR) << name() << ": Permission features must specify at least one "
+ << "value for extension_types.";
+ return false;
+ }
+
+ if (!GetContexts()->empty()) {
+ LOG(ERROR) << name() << ": Permission features do not support contexts.";
+ return false;
+ }
+ return true;
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698