chrome/browser/ui/find_bar/find_tab_helper.cc - Issue 128453002: Move Find Operations from RenderViewHost to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_tab_helper.cc

Issue 128453002: Move Find Operations from RenderViewHost to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | content/browser/web_contents/web_contents_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_tab_helper.cc

diff --git a/chrome/browser/ui/find_bar/find_tab_helper.cc b/chrome/browser/ui/find_bar/find_tab_helper.cc

index f0ad3b57e89d20ec95df6372def33b599f223c05..8a3570f750f53f303f90d39e83f7a1d2d391072a 100644

--- a/chrome/browser/ui/find_bar/find_tab_helper.cc

+++ b/chrome/browser/ui/find_bar/find_tab_helper.cc

@@ -89,8 +89,7 @@ void FindTabHelper::StartFinding(base::string16 search_string,

options.forward = forward_direction;

options.matchCase = case_sensitive;

options.findNext = find_next;

- web_contents()->GetRenderViewHost()->Find(current_find_request_id_,

- find_text_, options);

+ web_contents()->Find(current_find_request_id_, find_text_, options);

}

void FindTabHelper::StopFinding(

@@ -124,7 +123,7 @@ void FindTabHelper::StopFinding(

NOTREACHED();

action = content::STOP_FIND_ACTION_KEEP_SELECTION;

}

- web_contents()->GetRenderViewHost()->StopFinding(action);

+ web_contents()->StopFinding(action);

}

#if defined(OS_ANDROID)