content/browser/web_contents/web_contents_impl.h - Issue 128453002: Move Find Operations from RenderViewHost to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 128453002: Move Find Operations from RenderViewHost to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/browser/render_view_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 1f58fdc410f4f3358782c749a978d5fea40bf3db..8d5ef34c2e511f54d31c5c57c9763a89bcb168e0 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -283,6 +283,9 @@ class CONTENT_EXPORT WebContentsImpl

uint32_t max_bitmap_size,

const ImageDownloadCallback& callback) OVERRIDE;

virtual bool IsSubframe() const OVERRIDE;

+ virtual void Find(int request_id, const base::string16& search_text,

nasko 2014/01/08 17:29:13 style: arguments are on separate lines in declarat

Fady Samuel 2014/01/08 17:39:57 Done.

+ const blink::WebFindOptions& options) OVERRIDE;

+ virtual void StopFinding(StopFindAction action) OVERRIDE;

#if defined(OS_ANDROID)

virtual base::android::ScopedJavaLocalRef<jobject> GetJavaWebContents()

OVERRIDE;