Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 128453002: Move Find Operations from RenderViewHost to WebContents (Closed)

Created:
6 years, 11 months ago by Fady Samuel
Modified:
6 years, 11 months ago
Reviewers:
jam, boliu, nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, miu+watch_chromium.org, robertshield, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move Find Operations from RenderViewHost to WebContents BUG=330843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243709

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed nits #

Patch Set 3 : Addressed jam@'s nit #

Patch Set 4 : Fixed android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M android_webview/browser/find_helper.cc View 1 2 3 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 2 3 chunks +0 lines, -10 lines 0 comments Download
M content/public/browser/web_contents.h View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Fady Samuel
6 years, 11 months ago (2014-01-08 15:44:56 UTC) #1
nasko
LGTM with a couple of style issues. https://codereview.chromium.org/128453002/diff/1/content/browser/web_contents/web_contents_impl.h File content/browser/web_contents/web_contents_impl.h (right): https://codereview.chromium.org/128453002/diff/1/content/browser/web_contents/web_contents_impl.h#newcode286 content/browser/web_contents/web_contents_impl.h:286: virtual void ...
6 years, 11 months ago (2014-01-08 17:29:13 UTC) #2
Fady Samuel
+jam@ for content/public change OWNER approval. https://codereview.chromium.org/128453002/diff/1/content/browser/web_contents/web_contents_impl.h File content/browser/web_contents/web_contents_impl.h (right): https://codereview.chromium.org/128453002/diff/1/content/browser/web_contents/web_contents_impl.h#newcode286 content/browser/web_contents/web_contents_impl.h:286: virtual void Find(int ...
6 years, 11 months ago (2014-01-08 17:39:57 UTC) #3
jam
lgtm https://codereview.chromium.org/128453002/diff/1/content/public/browser/render_view_host.h File content/public/browser/render_view_host.h (right): https://codereview.chromium.org/128453002/diff/1/content/public/browser/render_view_host.h#newcode15 content/public/browser/render_view_host.h:15: #include "content/public/common/stop_find_action.h" nit: remove now
6 years, 11 months ago (2014-01-08 18:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/128453002/130001
6 years, 11 months ago (2014-01-08 18:16:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=105164
6 years, 11 months ago (2014-01-08 19:22:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/128453002/400001
6 years, 11 months ago (2014-01-08 19:40:02 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43872
6 years, 11 months ago (2014-01-08 20:01:18 UTC) #8
Fady Samuel
+boliu@ for android_webview/ OWNER review
6 years, 11 months ago (2014-01-08 21:14:10 UTC) #9
boliu
aw lgtm
6 years, 11 months ago (2014-01-08 21:30:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/128453002/400001
6 years, 11 months ago (2014-01-08 21:40:26 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 00:32:11 UTC) #12
Message was sent while issue was closed. 
Change committed as 243709

Powered by Google App Engine
This is Rietveld 408576698