Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: android_webview/browser/find_helper.cc

Issue 128453002: Move Find Operations from RenderViewHost to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed android build Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/find_helper.cc
diff --git a/android_webview/browser/find_helper.cc b/android_webview/browser/find_helper.cc
index bf6f71206d4259e3d57a9b319660035b7faf1855..9a66f0770e58f71f167d4deff451157b77b306a5 100644
--- a/android_webview/browser/find_helper.cc
+++ b/android_webview/browser/find_helper.cc
@@ -37,8 +37,7 @@ void FindHelper::SetListener(Listener* listener) {
void FindHelper::FindAllAsync(const base::string16& search_string) {
// Stop any ongoing asynchronous request.
- web_contents()->GetRenderViewHost()->StopFinding(
- content::STOP_FIND_ACTION_KEEP_SELECTION);
+ web_contents()->StopFinding(content::STOP_FIND_ACTION_KEEP_SELECTION);
sync_find_started_ = false;
async_find_started_ = true;
@@ -49,8 +48,7 @@ void FindHelper::FindAllAsync(const base::string16& search_string) {
options.findNext = false;
StartNewRequest(search_string);
- web_contents()->GetRenderViewHost()->Find(current_request_id_,
- search_string, options);
+ web_contents()->Find(current_request_id_, search_string, options);
}
void FindHelper::HandleFindReply(int request_id,
@@ -74,14 +72,11 @@ void FindHelper::FindNext(bool forward) {
options.matchCase = false;
options.findNext = true;
- web_contents()->GetRenderViewHost()->Find(current_request_id_,
- last_search_string_,
- options);
+ web_contents()->Find(current_request_id_, last_search_string_, options);
}
void FindHelper::ClearMatches() {
- web_contents()->GetRenderViewHost()->StopFinding(
- content::STOP_FIND_ACTION_CLEAR_SELECTION);
+ web_contents()->StopFinding(content::STOP_FIND_ACTION_CLEAR_SELECTION);
sync_find_started_ = false;
async_find_started_ = false;
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698