Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1284363002: Revert of Normalize SkXfermode_opts.h argument order as d,s[,aa]. (Closed)

Created:
5 years, 4 months ago by mtklein
Modified:
5 years, 4 months ago
Reviewers:
djsollen, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Normalize SkXfermode_opts.h argument order as d,s[,aa]. (patchset #1 id:1 of https://codereview.chromium.org/1289903002/ ) Reason for revert: ? Original issue's description: > Normalize SkXfermode_opts.h argument order as d,s[,aa]. > > At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa] > so we ended up having to write weird little lambda shims to match impedance. > > There's no reason for these to disagree, and d,s[,aa] is the One True Order > (because no matter what you're doing in graphics, there's always a dst). > > Should be no perf or image diff, though I'm suspicious it might help MSVC code generation. > > BUG=skia:4117 > > Committed: https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f TBR=djsollen@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/0010945335b497ee08ef12e1ce862ff2fefb8e01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M src/opts/SkXfermode_opts.h View 7 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Normalize SkXfermode_opts.h argument order as d,s[,aa].
5 years, 4 months ago (2015-08-12 20:51:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284363002/1
5 years, 4 months ago (2015-08-12 20:51:23 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 20:51:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0010945335b497ee08ef12e1ce862ff2fefb8e01

Powered by Google App Engine
This is Rietveld 408576698