Suppress error notifications and detailed view during OOBE

Suppress error notifications and detailed view during OOBE


BUG=222113, 222104
For ash/ash_chromeos_strings.grdp
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190458

[stevenjb, 2013-03-22 23:21:06]

https://codereview.chromium.org/12843019/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_state_notifier.cc (right):

https://codereview.chromium.org/12843019/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_state_notifier.cc:100:
StringToLowerASCII(std::string(flimflam::kUnknownString))) {
Shill uses both UNKNOWN and Unknown, so do a case insensitive compare here.

https://codereview.chromium.org/12843019/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_state_notifier.cc:104: UTF8ToUTF16(error));
In the case of an actual unrecognized error (shouldn't actually happen), better
to show the Shill string which may or may not be helpful.

https://codereview.chromium.org/12843019/diff/1/ash/system/tray/system_tray_i...
File ash/system/tray/system_tray_item.cc (right):

https://codereview.chromium.org/12843019/diff/1/ash/system/tray/system_tray_i...
ash/system/tray/system_tray_item.cc:62: return;
This is really just a safety net now that we are suppressing the network
notifications, but if we decide to turn on network or other notifications in the
tray, we still don't want to show detailed views during OOBE.

[jennyz, 2013-03-22 23:33:33]

lgtm

[commit-bot: I haz the power, 2013-03-23 00:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12843019/1

[commit-bot: I haz the power, 2013-03-23 00:08:13]

Presubmit check for 12843019-1 failed and returned exit status 1.

INFO:root:Found 8 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ash/ash_chromeos_strings.grdp

Presubmit checks took 1.0s to calculate.

[commit-bot: I haz the power, 2013-03-23 00:59:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12843019/1

[commit-bot: I haz the power, 2013-03-23 15:39:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12843019/1

[commit-bot: I haz the power, 2013-03-23 17:00:23]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[stevenjb, 2013-03-25 19:26:34]

Committed patchset #2 manually as r190458 (presubmit successful).