Suppress error notifications and detailed view during OOBE

ash/system/tray/system_tray_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray_item.h"
 
+#include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
+#include "ash/system/tray/system_tray_delegate.h"
 #include "ui/views/view.h"
 
 namespace ash {
 
 SystemTrayItem::SystemTrayItem(SystemTray* system_tray)
     : system_tray_(system_tray) {
 }
 
 SystemTrayItem::~SystemTrayItem() {
 }
@@ skipping 30 matching lines @@
   system_tray()->ShowDetailedView(this, 0, true, BUBBLE_USE_EXISTING);
 }
 
 void SystemTrayItem::UpdateAfterLoginStatusChange(user::LoginStatus status) {
 }
 
 void SystemTrayItem::UpdateAfterShelfAlignmentChange(ShelfAlignment alignment) {
 }
 
 void SystemTrayItem::PopupDetailedView(int for_seconds, bool activate) {
+  // Never show a detailed view during OOBE, e.g. from a notification.
+  if (!Shell::GetInstance()->system_tray_delegate()->IsOobeCompleted())
+    return;

[stevenjb, 2013/03/22 23:21:06]

This is really just a safety net now that we are suppressing the network
notifications, but if we decide to turn on network or other notifications in the
tray, we still don't want to show detailed views during OOBE.

   system_tray()->ShowDetailedView(
       this, for_seconds, activate, BUBBLE_CREATE_NEW);
 }
 
 void SystemTrayItem::SetDetailedViewCloseDelay(int for_seconds) {
   system_tray()->SetDetailedViewCloseDelay(for_seconds);
 }
 
 void SystemTrayItem::HideDetailedView() {
   system_tray()->HideDetailedView(this);
 }
 
 void SystemTrayItem::ShowNotificationView() {
   system_tray()->ShowNotificationView(this);
 }
 
 void SystemTrayItem::HideNotificationView() {
   system_tray()->HideNotificationView(this);
 }
 
 bool SystemTrayItem::ShouldHideArrow() const {
   return false;
 }
 
 bool SystemTrayItem::ShouldShowLauncher() const {
   return true;
 }
 
 }  // namespace ash