Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 12843018: Merge 145856 "Check to ensure MultisampleRenderbuffer creation s..." (Closed)

Created:
7 years, 9 months ago by Zhenyao Mo
Modified:
7 years, 9 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145856 "Check to ensure MultisampleRenderbuffer creation s..." > Check to ensure MultisampleRenderbuffer creation succeeds > https://bugs.webkit.org/show_bug.cgi?id=111780 > > Patch by Brandon Jones <bajones@google.com>; on 2013-03-14 > Reviewed by Kenneth Russell. > > On OSX systems using AMD graphics chips the allocation of large > Multisample Renderbuffers in Chromium would fail without any indication > of failure. Attempting to draw to the buffer resulted in garbage being > rendered onscreen. This could be reproduced by opening a full-page > WebGL app and pressing (Command + "-") several times. This patch adds an > additional check during DrawingBuffer resize to verify that the resized > buffer is valid. > > * platform/graphics/gpu/DrawingBuffer.cpp: > (WebCore): > (WebCore::DrawingBuffer::checkBufferIntegrity): > (WebCore::DrawingBuffer::reset): > * platform/graphics/gpu/DrawingBuffer.h: > (DrawingBuffer): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M Source/WebCore/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp View 4 chunks +47 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
7 years, 9 months ago (2013-03-22 23:01:51 UTC) #1
Zhenyao Mo
7 years, 9 months ago (2013-03-22 23:02:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r146671.

Powered by Google App Engine
This is Rietveld 408576698