Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284293003: Rename tracing interfaces. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
jamesr, rudominer
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -349 lines) Patch
M mojo/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/dart/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/common/dart/lib/trace_controller_impl.dart View 1 chunk +0 lines, -46 lines 0 comments Download
A + mojo/common/dart/lib/trace_provider_impl.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M mojo/common/dart/lib/tracing_helper.dart View 3 chunks +4 lines, -4 lines 0 comments Download
D mojo/common/trace_controller_impl.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/common/trace_controller_impl.cc View 1 chunk +0 lines, -55 lines 0 comments Download
A + mojo/common/trace_provider_impl.h View 3 chunks +11 lines, -12 lines 0 comments Download
A + mojo/common/trace_provider_impl.cc View 3 chunks +15 lines, -16 lines 0 comments Download
M mojo/common/tracing_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/common/tracing_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/tracing/public/interfaces/tracing.mojom View 1 chunk +9 lines, -9 lines 0 comments Download
M services/debugger/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D services/tracing/collector_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D services/tracing/collector_impl.cc View 1 chunk +0 lines, -29 lines 0 comments Download
A services/tracing/trace_recorder_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A + services/tracing/trace_recorder_impl.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M services/tracing/tracing_app.h View 3 chunks +9 lines, -9 lines 0 comments Download
M services/tracing/tracing_app.cc View 8 chunks +31 lines, -30 lines 0 comments Download
M shell/context.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M shell/tracer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M shell/tracer.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi James, Mitch, James, can you ptal at the mojom and C++ part? Mitch, can ...
5 years, 4 months ago (2015-08-12 18:09:34 UTC) #2
jamesr
lgtm
5 years, 4 months ago (2015-08-12 19:27:05 UTC) #3
rudominer
lgtm
5 years, 4 months ago (2015-08-12 20:27:39 UTC) #4
ppi
5 years, 4 months ago (2015-08-13 08:27:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4825af91a55f4c3b5307c20b4a797a96aef3edf7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698