Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: mojo/common/dart/lib/trace_provider_impl.dart

Issue 1284293003: Rename tracing interfaces. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/dart/lib/trace_controller_impl.dart ('k') | mojo/common/dart/lib/tracing_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/dart/lib/trace_provider_impl.dart
diff --git a/mojo/common/dart/lib/trace_controller_impl.dart b/mojo/common/dart/lib/trace_provider_impl.dart
similarity index 52%
rename from mojo/common/dart/lib/trace_controller_impl.dart
rename to mojo/common/dart/lib/trace_provider_impl.dart
index b56b4e25e2ffa08a3ea3a0e173608559e51bfee2..13901e09a7fae65ee43c800ecafe3369315dfad6 100644
--- a/mojo/common/dart/lib/trace_controller_impl.dart
+++ b/mojo/common/dart/lib/trace_provider_impl.dart
@@ -9,38 +9,38 @@ import 'package:mojo/bindings.dart';
import 'package:mojo/core.dart';
import 'package:mojo_services/tracing/tracing.mojom.dart';
-class TraceControllerImpl implements TraceController {
- TraceControllerStub _stub;
- TraceDataCollectorProxy _collector;
+class TraceProviderImpl implements TraceProvider {
+ TraceProviderStub _stub;
+ TraceRecorderProxy _recorder;
// TODO(rudominer) We currently ignore _categories.
String _categories;
- TraceControllerImpl.fromEndpoint(MojoMessagePipeEndpoint e) {
- _stub = TraceControllerStub.newFromEndpoint(e);
+ TraceProviderImpl.fromEndpoint(MojoMessagePipeEndpoint e) {
+ _stub = TraceProviderStub.newFromEndpoint(e);
_stub.impl = this;
}
@override
- void startTracing(String categories, TraceDataCollectorProxy collector) {
- assert(_collector == null);
- _collector = collector;
+ void startTracing(String categories, TraceRecorderProxy recorder) {
+ assert(_recorder == null);
+ _recorder = recorder;
_categories = categories;
}
@override
void stopTracing() {
- assert(_collector != null);
- _collector.close();
- _collector = null;
+ assert(_recorder != null);
+ _recorder.close();
+ _recorder = null;
}
bool isActive() {
- return _collector != null;
+ return _recorder != null;
}
void sendTraceMessage(String message) {
- if (_collector != null) {
- _collector.ptr.dataCollected(message);
+ if (_recorder != null) {
+ _recorder.ptr.record(message);
}
}
}
« no previous file with comments | « mojo/common/dart/lib/trace_controller_impl.dart ('k') | mojo/common/dart/lib/tracing_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698