Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1284243004: Prefer native scaling to sampling (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 3 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Prefer native scaling to sampling In the cases we have come across so far, native scaling has better performance and correctness than sampling. If native scaling is supported we want to use it. Jpegs native scale rounds up. Ex: An 11x11 image with sampleSize=8 scales to 2x2. SkScaledCodec rounds down. Ex: An 11x11 image with sampleSize=8 scales to 1x1. Before the CL, we would choose to use SkScaledCodec because it scales closer to the "ideal" scale. I think we want to go with the native option as long as its within 1 of the ideal value. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a83593b88a38765eba5f349d4e12d66b3e626af9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/codec/SkScaledCodec.cpp View 3 chunks +11 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
msarett
In the cases we have come across so far, native scaling has better performance and ...
5 years, 4 months ago (2015-08-18 14:31:02 UTC) #2
msarett
5 years, 4 months ago (2015-08-18 14:31:11 UTC) #4
djsollen
lgtm
5 years, 4 months ago (2015-08-18 14:55:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284243004/1
5 years, 4 months ago (2015-08-18 14:57:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a83593b88a38765eba5f349d4e12d66b3e626af9
5 years, 4 months ago (2015-08-18 15:04:02 UTC) #8
scroggo
5 years, 3 months ago (2015-08-27 21:41:00 UTC) #9
Message was sent while issue was closed.
On 2015/08/18 15:04:02, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/a83593b88a38765eba5f349d4e12d66b3e626af9

LGTM

Powered by Google App Engine
This is Rietveld 408576698