[CacheStorage] Use appopriate type parameters for WebCallbacks (1/3).

[CacheStorage] Use appopriate type parameters for WebCallbacks (1/3).

This series of CLs fixes WebCallback parameter types used in CacheStorage.

 - WebServiceWorkerResponse* (ownership not transferred)
  => const WebServiceWorkerResponse&
 - WebVector<WebServiceWorkerResponse>* (ownership not transferred)
  => const WebVector<WebServiceWorkerResponse>&
 - WebVector<WebServiceWorkerRequest>* (ownership not transferred)
  => const WebVector<WebServiceWorkerRequest>&
 - WebServiceWorkerCache* (ownership transferred)
  => WebPassOwnPtr<WebServiceWorkerCache>
 - WebVector<WebString>* (ownership not transferred)
  => const WebVector<WebString>&
 - WebServiceWorkerCacheError* (ownership transferred)
  => WebServiceWorkerCacheError

1/3: https://codereview.chromium.org/1284173004/
2/3: https://codereview.chromium.org/1284283003/
3/3: https://codereview.chromium.org/1296723005/

BUG=493531
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200825

[yhirano, 2015-08-19 10:26:53]

yhirano@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2015-08-19 11:25:14]

lgtm

https://codereview.chromium.org/1284173004/diff/20001/Source/modules/cachesto...
File Source/modules/cachestorage/CacheStorage.cpp (right):

https://codereview.chromium.org/1284173004/diff/20001/Source/modules/cachesto...
Source/modules/cachestorage/CacheStorage.cpp:60: // Ownership of |rawReason|
must be passed.
nit: Can you remove this comment?

https://codereview.chromium.org/1284173004/diff/20001/Source/modules/cachesto...
Source/modules/cachestorage/CacheStorage.cpp:86: OwnPtr<WebServiceWorkerCache>
webCache = rawWebCache.release();
How about removing this indirection and directly passing rawWebCache to
Cache::create? And then, renaming rawWebCache to webCache?

[yhirano, 2015-08-19 11:34:58]

https://codereview.chromium.org/1284173004/diff/20001/Source/modules/cachesto...
File Source/modules/cachestorage/CacheStorage.cpp (right):

https://codereview.chromium.org/1284173004/diff/20001/Source/modules/cachesto...
Source/modules/cachestorage/CacheStorage.cpp:60: // Ownership of |rawReason|
must be passed.
On 2015/08/19 11:25:14, nhiroki wrote:
> nit: Can you remove this comment?

Done.

https://codereview.chromium.org/1284173004/diff/20001/Source/modules/cachesto...
Source/modules/cachestorage/CacheStorage.cpp:86: OwnPtr<WebServiceWorkerCache>
webCache = rawWebCache.release();
On 2015/08/19 11:25:14, nhiroki wrote:
> How about removing this indirection and directly passing rawWebCache to
> Cache::create? And then, renaming rawWebCache to webCache?

Done.

[yhirano, 2015-08-19 11:35:03]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-08-19 11:35:03]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1284173004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-19 11:35:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284173004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284173004/40001

[commit-bot: I haz the power, 2015-08-19 13:13:25]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200825