Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: public/platform/modules/serviceworker/WebServiceWorkerCache.h

Issue 1284173004: [CacheStorage] Use appopriate type parameters for WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/serviceworker/WebServiceWorkerCache.h
diff --git a/public/platform/modules/serviceworker/WebServiceWorkerCache.h b/public/platform/modules/serviceworker/WebServiceWorkerCache.h
index d8044b065da0aa10a79f5955a45004650fbc1bac..17c9ad0cf39934b81a106918aa886d7a85325966 100644
--- a/public/platform/modules/serviceworker/WebServiceWorkerCache.h
+++ b/public/platform/modules/serviceworker/WebServiceWorkerCache.h
@@ -20,9 +20,39 @@ namespace blink {
// This object is owned by Blink, and should be destroyed as each Cache instance is no longer in use.
class WebServiceWorkerCache {
public:
- using CacheMatchCallbacks = WebCallbacks<WebServiceWorkerResponse*, WebServiceWorkerCacheError*>;
- using CacheWithResponsesCallbacks = WebCallbacks<WebVector<WebServiceWorkerResponse>*, WebServiceWorkerCacheError*>;
- using CacheWithRequestsCallbacks = WebCallbacks<WebVector<WebServiceWorkerRequest>*, WebServiceWorkerCacheError*>;
+ class CacheMatchCallbacks : public WebCallbacks<const WebServiceWorkerResponse&, WebServiceWorkerCacheError> {
+ public:
+ void onSuccess(WebServiceWorkerResponse* r) { onSuccess(*r); }
+ void onError(WebServiceWorkerCacheError* e)
+ {
+ onError(*e);
+ delete e;
+ }
+ void onSuccess(const WebServiceWorkerResponse&) override {}
+ void onError(WebServiceWorkerCacheError) override {}
+ };
+ class CacheWithResponsesCallbacks : public WebCallbacks<const WebVector<WebServiceWorkerResponse>&, WebServiceWorkerCacheError> {
+ public:
+ void onSuccess(WebVector<WebServiceWorkerResponse>* r) { onSuccess(*r); }
+ void onError(WebServiceWorkerCacheError* e)
+ {
+ onError(*e);
+ delete e;
+ }
+ void onSuccess(const WebVector<WebServiceWorkerResponse>&) override {}
+ void onError(WebServiceWorkerCacheError) override {}
+ };
+ class CacheWithRequestsCallbacks : public WebCallbacks<const WebVector<WebServiceWorkerRequest>&, WebServiceWorkerCacheError> {
+ public:
+ void onSuccess(WebVector<WebServiceWorkerRequest>* r) { onSuccess(*r); }
+ void onError(WebServiceWorkerCacheError* e)
+ {
+ onError(*e);
+ delete e;
+ }
+ void onSuccess(const WebVector<WebServiceWorkerRequest>&) override {}
+ void onError(WebServiceWorkerCacheError) override {}
+ };
using CacheBatchCallbacks = WebCallbacks<void, WebServiceWorkerCacheError>;
virtual ~WebServiceWorkerCache() { }

Powered by Google App Engine
This is Rietveld 408576698