Add Unicode Variation Selector support on Linux official builds

Add Unicode Variation Selector support on Linux official builds

Most of the work to support Unicode Variation Selector was done in a
separate CL[1], but it was not enabled for Linux due to crbug.com/462689.

This patch enables the Unicode Variation Selector support on Linux
official builds.

The CL to enable on all Linux[2] was reverted because chromeos=1 is still
bound to the harfbuzz in the system and thus unable to use
hb_ot_font_set_funcs() on Trusty.

[1] https://codereview.chromium.org/1149693002/
[2] https://codereview.chromium.org/1209043010/

BUG=383580
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200427

[kojii, 2015-08-12 05:15:42]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2015-08-12 05:15:43]

PTAL. Another try, just for OFFICIAL_BUILD. It does not help devs to use bundled
HB, but we can enable on shipped versions for Linux and ChromeOS.

[eae, 2015-08-12 20:24:00]

LGTM

Thanks for sticking with this problem!

[eae, 2015-08-12 20:24:04]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2015-08-12 20:24:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283923002/1

[commit-bot: I haz the power, 2015-08-12 21:22:03]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200427

[fukino, 2015-08-13 03:08:39]

On 2015/08/12 21:22:03, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=200427

With this CL, I encountered following compile error.

../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:176:13:
error: use of undeclared identifier 'hb_ot_font_set_funcs'
            hb_ot_font_set_funcs(hbFontData->m_hbOpenTypeFont);

I'm building Chrome for ChromeOS on Linux with official build flag.
GYP_DEFINES="chromeos=1 branding=Chrome buildtype=Official use_goma=1
component=shared_library remove_webcore_debug_symbols=1"

Can I work around this error?

[kojii, 2015-08-13 03:29:40]

On 2015/08/13 03:08:39, fukino wrote:
> On 2015/08/12 21:22:03, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> > https://src.chromium.org/viewvc/blink?view=rev&revision=200427
> 
> With this CL, I encountered following compile error.
> 
>
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:176:13:
> error: use of undeclared identifier 'hb_ot_font_set_funcs'
>             hb_ot_font_set_funcs(hbFontData->m_hbOpenTypeFont);
> 
> I'm building Chrome for ChromeOS on Linux with official build flag.
> GYP_DEFINES="chromeos=1 branding=Chrome buildtype=Official use_goma=1
> component=shared_library remove_webcore_debug_symbols=1"
> 
> Can I work around this error?

It's not for bots, correct?

I didn't count anyone other than bots are using bulidtype=Official. Does the
"use_system_harfbuzz=0" help?

[rsadam, 2015-08-18 19:42:30]

On 2015/08/13 03:29:40, kojii wrote:
> On 2015/08/13 03:08:39, fukino wrote:
> > On 2015/08/12 21:22:03, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > > https://src.chromium.org/viewvc/blink?view=rev&revision=200427
> > 
> > With this CL, I encountered following compile error.
> > 
> >
>
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:176:13:
> > error: use of undeclared identifier 'hb_ot_font_set_funcs'
> >             hb_ot_font_set_funcs(hbFontData->m_hbOpenTypeFont);
> > 
> > I'm building Chrome for ChromeOS on Linux with official build flag.
> > GYP_DEFINES="chromeos=1 branding=Chrome buildtype=Official use_goma=1
> > component=shared_library remove_webcore_debug_symbols=1"
> > 
> > Can I work around this error?
> 
> It's not for bots, correct?
> 
> I didn't count anyone other than bots are using bulidtype=Official. Does the
> "use_system_harfbuzz=0" help?

use_system_harfbuzz=0 prevents the compiler errors, but causes linker errors.
Reverting this CL locally enables regular building (though the linker errors
still exist with use_system_harfbuzz=0).

[rsadam, 2015-08-18 19:45:16]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1292583006/ by rsadam@chromium.org.

The reason for reverting is: This CL prevents building official Chrome images on
Linux.

../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:176:13:
error: use of undeclared identifier 'hb_ot_font_set_funcs'

The proposed workaround doesn't work, so reverting this CL..