Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2498)

Unified Diff: Source/platform/fonts/shaping/HarfBuzzFace.cpp

Issue 1283923002: Add Unicode Variation Selector support on Linux official builds (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/shaping/HarfBuzzFace.cpp
diff --git a/Source/platform/fonts/shaping/HarfBuzzFace.cpp b/Source/platform/fonts/shaping/HarfBuzzFace.cpp
index 1fbc51207acad85afa595ce91d7302f4e7ab9b62..ef2aa6a18eda9ada689a4814f6794ec86b529987 100644
--- a/Source/platform/fonts/shaping/HarfBuzzFace.cpp
+++ b/Source/platform/fonts/shaping/HarfBuzzFace.cpp
@@ -162,9 +162,10 @@ static hb_bool_t harfBuzzGetGlyph(hb_font_t* hbFont, void* fontData, hb_codepoin
HarfBuzzFontData* hbFontData = reinterpret_cast<HarfBuzzFontData*>(fontData);
if (variationSelector) {
-#if OS(LINUX)
- // TODO(kojii): Linux non-official builds cannot use new HB APIs
- // until crbug.com/462689 resolved or pangoft2 updates its HB.
+#if OS(LINUX) && !defined(OFFICIAL_BUILD)
+ // TODO(kojii): Linux non-official builds cannot use hb_ot_font_set_funcs()
+ // until we find a way to bundle HB in non-official builds, or pangoft2
+ // updates its HB. See crbug.com/462689.
return false;
#else
// Skia does not support variation selectors, but hb does.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698