Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/simulator_mips.cc

Issue 12837009: Adds MIPS SPECIAL instructions to simulator, assembler, debugger. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/disassembler_mips.cc ('K') | « runtime/vm/disassembler_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/simulator_mips.cc
===================================================================
--- runtime/vm/simulator_mips.cc (revision 20092)
+++ runtime/vm/simulator_mips.cc (working copy)
@@ -757,6 +757,28 @@
set_hi_register(rs_val % rt_val);
break;
}
+ case JALR: {
+ ASSERT(instr->RtField() == R0);
Ivan Posva 2013/03/20 01:54:51 I would expect some of these asserts also in the d
zra 2013/03/20 15:53:50 See explanation for sra.
+ ASSERT(instr->RsField() != instr->RdField());
+ ASSERT(!delay_slot_);
+ // Format(instr, "jalr'hint 'rd, rs");
+ uword next_pc = get_register(instr->RsField());
+ ExecuteDelaySlot();
+ // Set return address to be the instruction after the delay slot.
+ set_register(instr->RdField(), pc_ + Instr::kInstrSize);
+ pc_ = next_pc - Instr::kInstrSize; // Account for regular PC increment.
+ break;
+ }
+ case JR: {
+ ASSERT(instr->RtField() == R0);
+ ASSERT(instr->RdField() == R0);
+ ASSERT(!delay_slot_);
+ // Format(instr, "jr'hint 'rs");
+ uword next_pc = get_register(instr->RsField());
+ ExecuteDelaySlot();
+ pc_ = next_pc - Instr::kInstrSize; // Account for regular PC increment.
+ break;
+ }
case MFHI: {
ASSERT(instr->RsField() == 0);
ASSERT(instr->RtField() == 0);
@@ -773,6 +795,64 @@
set_register(instr->RdField(), get_lo_register());
break;
}
+ case MOVN: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "movn 'rd, 'rs, 'rt");
+ int32_t rt_val = get_register(instr->RtField());
+ int32_t rs_val = get_register(instr->RsField());
+ if (rt_val != 0) {
+ set_register(instr->RdField(), rs_val);
+ }
+ break;
+ }
+ case MOVZ: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "movz 'rd, 'rs, 'rt");
+ int32_t rt_val = get_register(instr->RtField());
+ int32_t rs_val = get_register(instr->RsField());
+ if (rt_val == 0) {
+ set_register(instr->RdField(), rs_val);
+ }
+ break;
+ }
+ case MULT: {
+ ASSERT(instr->RdField() == 0);
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "mult 'rs, 'rt");
+ int64_t rs = static_cast<int64_t>(get_register(instr->RsField()));
+ int64_t rt = static_cast<int64_t>(get_register(instr->RtField()));
+ int64_t res = rs * rt;
+ set_hi_register(Utils::High32Bits(res));
+ set_lo_register(Utils::Low32Bits(res));
+ break;
+ }
+ case MULTU: {
+ ASSERT(instr->RdField() == 0);
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "multu 'rs, 'rt");
+ uint64_t rs = static_cast<uint64_t>(get_register(instr->RsField()));
+ uint64_t rt = static_cast<uint64_t>(get_register(instr->RtField()));
+ uint64_t res = rs * rt;
+ set_hi_register(Utils::High32Bits(res));
+ set_lo_register(Utils::Low32Bits(res));
+ break;
+ }
+ case NOR: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "nor 'rd, 'rs, 'rt");
+ int32_t rs_val = get_register(instr->RsField());
+ int32_t rt_val = get_register(instr->RtField());
+ set_register(instr->RdField(), ~(rs_val | rt_val));
+ break;
+ }
+ case OR: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "or 'rd, 'rs, 'rt");
+ int32_t rs_val = get_register(instr->RsField());
+ int32_t rt_val = get_register(instr->RtField());
+ set_register(instr->RdField(), rs_val | rt_val);
+ break;
+ }
case SLL: {
ASSERT(instr->RsField() == 0);
if ((instr->RdField() == R0) &&
@@ -787,16 +867,78 @@
}
break;
}
- case JR: {
- ASSERT(instr->RtField() == R0);
- ASSERT(instr->RdField() == R0);
- ASSERT(!delay_slot_);
- // Format(instr, "jr'hint 'rs");
- uword next_pc = get_register(instr->RsField());
- ExecuteDelaySlot();
- pc_ = next_pc - Instr::kInstrSize; // Account for regular PC increment.
+ case SLLV: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "sllv 'rd, 'rt, 'rs");
+ int32_t rt_val = get_register(instr->RtField());
+ int32_t rs_val = get_register(instr->RsField());
Ivan Posva 2013/03/20 01:54:51 SLLV takes only bits 0..4 from RS. Please add an a
zra 2013/03/20 15:53:50 Done.
+ set_register(instr->RdField(), rt_val << rs_val);
break;
}
+ case SLT: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "slt 'rd, 'rs, 'rt");
+ int32_t rs_val = get_register(instr->RsField());
+ int32_t rt_val = get_register(instr->RtField());
+ set_register(instr->RdField(), rs_val < rt_val ? 1 : 0);
+ break;
+ }
+ case SLTU: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "sltu 'rd, 'rs, 'rt");
+ uint32_t rs_val = get_register(instr->RsField());
Ivan Posva 2013/03/20 01:54:51 Should this include a static_cast<uint32_t> to cla
zra 2013/03/20 15:53:50 Done.
+ uint32_t rt_val = get_register(instr->RtField());
+ set_register(instr->RdField(), rs_val < rt_val ? 1 : 0);
+ break;
+ }
+ case SRA: {
+ ASSERT(instr->RsField() == 0);
+ // Format(instr, "sra 'rd, 'rt, 'sa");
+ int32_t rt_val = get_register(instr->RtField());
+ int32_t sa = instr->SaField();
+ set_register(instr->RdField(), rt_val >> sa);
+ break;
+ }
+ case SRAV: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "srav 'rd, 'rt, 'rs");
+ int32_t rt_val = get_register(instr->RtField());
+ int32_t rs_val = get_register(instr->RsField());
Ivan Posva 2013/03/20 01:54:51 ditto.
zra 2013/03/20 15:53:50 Done.
+ set_register(instr->RdField(), rt_val >> rs_val);
+ break;
+ }
+ case SRL: {
+ ASSERT(instr->RsField() == 0);
+ // Format(instr, "srl 'rd, 'rt, 'sa");
+ uint32_t rt_val = get_register(instr->RtField());
+ uint32_t sa = instr->SaField();
+ set_register(instr->RdField(), rt_val >> sa);
+ break;
+ }
+ case SRLV: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "srlv 'rd, 'rt, 'rs");
+ uint32_t rt_val = get_register(instr->RtField());
+ uint32_t rs_val = get_register(instr->RsField());
Ivan Posva 2013/03/20 01:54:51 ditto.
zra 2013/03/20 15:53:50 Done.
+ set_register(instr->RdField(), rt_val >> rs_val);
+ break;
+ }
+ case SUBU: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "subu 'rd, 'rs, 'rt");
+ int32_t rs_val = get_register(instr->RsField());
+ int32_t rt_val = get_register(instr->RtField());
+ set_register(instr->RdField(), rs_val - rt_val);
+ break;
+ }
+ case XOR: {
+ ASSERT(instr->SaField() == 0);
+ // Format(instr, "xor 'rd, 'rs, 'rt");
+ int32_t rs_val = get_register(instr->RsField());
+ int32_t rt_val = get_register(instr->RtField());
+ set_register(instr->RdField(), rs_val ^ rt_val);
+ break;
+ }
default: {
OS::PrintErr("DecodeSpecial: 0x%x\n", instr->InstructionBits());
UNIMPLEMENTED();
« runtime/vm/disassembler_mips.cc ('K') | « runtime/vm/disassembler_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698