Add networkingPrivate.getThirdPartyVpnProviderList

Add networkingPrivate.getThirdPartyVpnProviderList

This also:
* Adds 'Name' to ThirdPartyVPNProperties (corresponding to the ONC
  property)
* Adds networkingPrivate.onVpnProviderListChanged

This API will replace the UpdateVPNProviders code in InternetOptionsHandler and vpn_providers.js in a follow-up CL, and will be used in the new Settings UI.

BUG=516796

[stevenjb, 2015-08-11 19:21:37]

stevenjb@chromium.org changed reviewers:
+ bartfab@chromium.org, pneubeck@chromium.org

[pneubeck (no reviews), 2015-08-13 12:58:37]

please consider the alternative to this additional API function and event:
 https://developer.chrome.com/extensions/management#method-getAll allows you to
get all installed extensions&apps together with their permissions.
You could easily look for vpnProvider extensions in javascript using that API.

https://codereview.chromium.org/1283613005/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
(right):

https://codereview.chromium.org/1283613005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:858:
var done = chrome.test.callbackAdded();
nit: you could still use the callbackPass wrapper

https://codereview.chromium.org/1283613005/diff/40001/chromeos/network/networ...
File chromeos/network/network_util.h (left):

https://codereview.chromium.org/1283613005/diff/40001/chromeos/network/networ...
chromeos/network/network_util.h:104: // the number of results. If
|debugging_properties| is true then also include
I guess this is an orthogonal change?

https://codereview.chromium.org/1283613005/diff/40001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/1283613005/diff/40001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:247: const
int limit = params->filter.limit
orthogonal change?

https://codereview.chromium.org/1283613005/diff/40001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_chromeos.cc
(right):

https://codereview.chromium.org/1283613005/diff/40001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_chromeos.cc:639:
provider->name.reset(new std::string(extension->name()));
why not using
 https://developer.chrome.com/extensions/management#method-get
in the extension?
I.e.
  chrome.management.get(vpn_provider.ExtensionID, function(info) {
    vpn_provider_name = info.name
  });

that also allows to get other information of that extension, like short name or
the icon,

[stevenjb, 2015-08-13 15:45:06]

On 2015/08/13 12:58:37, pneubeck wrote:
> please consider the alternative to this additional API function and event:
>  https://developer.chrome.com/extensions/management#method-getAll allows you
to
> get all installed extensions&apps together with their permissions.
> You could easily look for vpnProvider extensions in javascript using that API.
> 

I wish the current Settings hand been implemented using that initially. I guess
I assumed that no such API existed. I will give it a try.

[stevenjb, 2015-08-13 22:09:51]

OK, it looks like chrome.management will do the trick. Closing this CL.