chromeos/network/network_util.h - Issue 1283613005: Add networkingPrivate.getThirdPartyVpnProviderList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_util.h

Issue 1283613005: Add networkingPrivate.getThirdPartyVpnProviderList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_515987_cr_network_list

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/networking_private/chromeos/test.js ('K') | « chrome/test/data/extensions/api_test/networking_private/test.js ('k') | chromeos/network/network_util.cc » ('j') | extensions/browser/api/networking_private/networking_private_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/network_util.h

diff --git a/chromeos/network/network_util.h b/chromeos/network/network_util.h

index f07fdaff6d152c33254195128839e49c4ffbcfe6..47cdcde623357e8d6a918dec97de1c56a516e497 100644

--- a/chromeos/network/network_util.h

+++ b/chromeos/network/network_util.h

@@ -101,14 +101,12 @@ CHROMEOS_EXPORT scoped_ptr<base::DictionaryValue> TranslateNetworkStateToONC(

// |configured_only|, and |visible_only| to NetworkStateHandler::

// GetNetworkListByType(). Translates the result into a list of ONC

// dictionaries using TranslateShillServiceToONCPart. |limit| is used to limit

-// the number of results. If |debugging_properties| is true then also include

pneubeck (no reviews) 2015/08/13 12:58:37 I guess this is an orthogonal change?

-// additional debugging properties (used in release code for chrome://network).

+// the number of results.

CHROMEOS_EXPORT scoped_ptr<base::ListValue> TranslateNetworkListToONC(

NetworkTypePattern pattern,

bool configured_only,

bool visible_only,

- int limit,

- bool debugging_properties);

+ int limit);

// Returns the Shill type corresponding to ONC |type| or an empty string if

// there is no match. Only valid for ethernet, wifi, wimax, cellular, and vpn.