Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1283593006: Remove owned views from AXAuraObjCache when widget is deleted. (Closed)

Created:
5 years, 4 months ago by dmazzoni
Modified:
5 years, 4 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, sadrul, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove owned views from AXAuraObjCache when widget is deleted. A follow-up change should notify automation clients, too. Even then, a CHECK() that an AX obj wrapper exists for a given ID doesn't make sense because the IPC could have been received after an object was deleted but before the client was informed of it. BUG=514728 Committed: https://crrev.com/9febb059904b30661543102a540cf8ae00a78cae Cr-Commit-Position: refs/heads/master@{#343061}

Patch Set 1 #

Patch Set 2 : nullptr check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
dmazzoni
5 years, 4 months ago (2015-08-10 19:37:10 UTC) #2
David Tseng
lgtm
5 years, 4 months ago (2015-08-10 20:38:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283593006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283593006/1
5 years, 4 months ago (2015-08-10 21:53:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/48580)
5 years, 4 months ago (2015-08-10 22:35:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283593006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283593006/20001
5 years, 4 months ago (2015-08-12 17:49:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 18:33:33 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:33:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9febb059904b30661543102a540cf8ae00a78cae
Cr-Commit-Position: refs/heads/master@{#343061}

Powered by Google App Engine
This is Rietveld 408576698