Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc

Issue 1283593006: Remove owned views from AXAuraObjCache when widget is deleted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nullptr check Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/accessibility/ax_aura_obj_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc
diff --git a/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc b/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc
index 6c6a585c8089e583b8e591f9a17030617ab0627f..ace43a5da318010b658525b53b129c1407a03f6f 100644
--- a/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc
+++ b/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc
@@ -28,32 +28,32 @@ AXTreeSourceAura::~AXTreeSourceAura() {
void AXTreeSourceAura::DoDefault(int32 id) {
AXAuraObjWrapper* obj = AXAuraObjCache::GetInstance()->Get(id);
- CHECK(obj);
- obj->DoDefault();
+ if (obj)
+ obj->DoDefault();
}
void AXTreeSourceAura::Focus(int32 id) {
AXAuraObjWrapper* obj = AXAuraObjCache::GetInstance()->Get(id);
- CHECK(obj);
- obj->Focus();
+ if (obj)
+ obj->Focus();
}
void AXTreeSourceAura::MakeVisible(int32 id) {
AXAuraObjWrapper* obj = AXAuraObjCache::GetInstance()->Get(id);
- CHECK(obj);
- obj->MakeVisible();
+ if (obj)
+ obj->MakeVisible();
}
void AXTreeSourceAura::SetSelection(int32 id, int32 start, int32 end) {
AXAuraObjWrapper* obj = AXAuraObjCache::GetInstance()->Get(id);
- CHECK(obj);
- obj->SetSelection(start, end);
+ if (obj)
+ obj->SetSelection(start, end);
}
void AXTreeSourceAura::ShowContextMenu(int32 id) {
AXAuraObjWrapper* obj = AXAuraObjCache::GetInstance()->Get(id);
- CHECK(obj);
- obj->ShowContextMenu();
+ if (obj)
+ obj->ShowContextMenu();
}
AXAuraObjWrapper* AXTreeSourceAura::GetRoot() const {
« no previous file with comments | « no previous file | ui/views/accessibility/ax_aura_obj_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698