Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Issue 1283513003: Make run-tests.py warn when it's not testing anything (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make run-tests.py warn when it's not testing anything I've often been confused by an "all passed" run of the test script when it turned out that either all the tests I cared about were skipped or, more likely, I mistyped the name(s) of the tests I wanted to run. This patch aims to fix that (and gives a useful diagnostic for the "all matched tests were skipped" case). R=machenbach@chromium.org NOTRY=true Committed: https://crrev.com/1b1de2d221a0ed23e529e91bf9fa3dc287acb2ca Cr-Commit-Position: refs/heads/master@{#30095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/run-tests.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
adamk
5 years, 4 months ago (2015-08-08 01:28:01 UTC) #1
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-08-08 22:01:39 UTC) #3
Michael Achenbach
lgtm
5 years, 4 months ago (2015-08-10 09:17:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283513003/1
5 years, 4 months ago (2015-08-10 18:14:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 18:16:29 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b1de2d221a0ed23e529e91bf9fa3dc287acb2ca Cr-Commit-Position: refs/heads/master@{#30095}
5 years, 4 months ago (2015-08-10 18:16:39 UTC) #8
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1283593005/ by machenbach@chromium.org. ...
5 years, 4 months ago (2015-08-10 18:54:32 UTC) #9
adamk
5 years, 4 months ago (2015-08-10 19:02:37 UTC) #10
Message was sent while issue was closed.
Sorry for the breakage, this one should have gone without NOTRY=true I guess.

Powered by Google App Engine
This is Rietveld 408576698