Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: tools/run-tests.py

Issue 1283513003: Make run-tests.py warn when it's not testing anything (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index a9a81f8299878ec09964242ea3ed5169e506c9be..7b4c5c122fd9cca363ae48a2ca2f2d230f7019cf 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -532,8 +532,6 @@ def Main():
def Execute(arch, mode, args, options, suites, workspace):
- print(">>> Running tests for %s.%s" % (arch, mode))
-
shell_dir = options.shell_dir
if not shell_dir:
if options.buildbot:
@@ -651,6 +649,14 @@ def Execute(arch, mode, args, options, suites, workspace):
if options.cat:
return 0 # We're done here.
+ if num_tests == 0:
+ print("No tests selected for running!")
+ if len(all_tests) > 0:
+ verbose.PrintReport(all_tests)
+ return 0
+
+ print(">>> Running tests for %s.%s" % (arch, mode))
+
if options.report:
verbose.PrintReport(all_tests)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698